com.capitalone.dashboard:core – SpotBugs Bug Detector Report

com.capitalone.dashboard:core

SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 3.1.11

Threshold is medium

Effort is default

Summary

Classes	Bugs	Errors	Missing Classes
382	32	0	0

Files

Class	Bugs
com.capitalone.dashboard.client.RestClient	1
com.capitalone.dashboard.config.collector.CloudConfig	2
com.capitalone.dashboard.event.BuildEventListener	1
com.capitalone.dashboard.event.EnvironmentComponentEventListener	3
com.capitalone.dashboard.event.TestResultEventListener	3
com.capitalone.dashboard.model.ChangeOrder	1
com.capitalone.dashboard.model.Commit	1
com.capitalone.dashboard.model.Configuration	2
com.capitalone.dashboard.model.KeyValueLog	1
com.capitalone.dashboard.model.LibraryPolicyResult$ThreatComponent	1
com.capitalone.dashboard.repository.CustomRepositoryQueryImpl	1
com.capitalone.dashboard.request.CloudInstanceListRefreshRequest	2
com.capitalone.dashboard.request.CloudSubnetListRefreshRequest	2
com.capitalone.dashboard.request.CloudVirtualNetworkListRefreshRequest	2
com.capitalone.dashboard.request.CloudVolumeListRefreshRequest	2
com.capitalone.dashboard.request.CommitCreateRequest	1
com.capitalone.dashboard.request.GitRequestCreateRequest	1
com.capitalone.dashboard.util.Encryption	4
com.capitalone.dashboard.util.SuperFeatureComparator	1

com.capitalone.dashboard.client.RestClient

Bug	Category	Details	Line	Priority
Found reliance on default encoding in com.capitalone.dashboard.client.RestClient.createHeaders(String): new String(byte[])	I18N	DM_DEFAULT_ENCODING	145	High

com.capitalone.dashboard.config.collector.CloudConfig

Bug	Category	Details	Line	Priority
Primitive value is unboxed and coerced for ternary operator in com.capitalone.dashboard.config.collector.CloudConfig.getMemoryAlert()	PERFORMANCE	BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR	72	Medium
Primitive value is unboxed and coerced for ternary operator in com.capitalone.dashboard.config.collector.CloudConfig.getMemoryError()	PERFORMANCE	BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR	68	Medium

com.capitalone.dashboard.event.BuildEventListener

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.event.BuildEventListener.processBuild(Build) makes inefficient use of keySet iterator instead of entrySet iterator	PERFORMANCE	WMI_WRONG_MAP_ITERATOR	112	Medium

com.capitalone.dashboard.event.EnvironmentComponentEventListener

Bug	Category	Details	Line	Priority
Redundant nullcheck of oldLastArtifact, which is known to be non-null in com.capitalone.dashboard.event.EnvironmentComponentEventListener.addCommitsToEnvironmentStage(EnvironmentComponent, Pipeline)	STYLE	RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE	134	High
Nullcheck of sortedArtifacts at line 164 of value previously dereferenced in com.capitalone.dashboard.event.EnvironmentComponentEventListener.addCommitsToEnvironmentStage(EnvironmentComponent, Pipeline)	CORRECTNESS	RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE	164	Medium
com.capitalone.dashboard.event.EnvironmentComponentEventListener.addCommitsToEnvironmentStage(EnvironmentComponent, Pipeline) makes inefficient use of keySet iterator instead of entrySet iterator	PERFORMANCE	WMI_WRONG_MAP_ITERATOR	195	Medium

com.capitalone.dashboard.event.TestResultEventListener

Bug	Category	Details	Line	Priority
Write to static field com.capitalone.dashboard.event.TestResultEventListener.errRateSeverityVal from instance method com.capitalone.dashboard.event.TestResultEventListener.getPerfMetrics(TestCapability)	STYLE	ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD	256	Medium
Write to static field com.capitalone.dashboard.event.TestResultEventListener.respTimeSeverityVal from instance method com.capitalone.dashboard.event.TestResultEventListener.getPerfMetrics(TestCapability)	STYLE	ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD	255	Medium
Write to static field com.capitalone.dashboard.event.TestResultEventListener.txnHealthPercentVal from instance method com.capitalone.dashboard.event.TestResultEventListener.getPerfMetrics(TestCapability)	STYLE	ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD	254	Medium

com.capitalone.dashboard.model.ChangeOrder

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.model.ChangeOrder.equals(Object) checks for operand being a Incident	BAD_PRACTICE	EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS	190	High

com.capitalone.dashboard.model.Commit

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.model.Commit doesn't override SCM.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium

com.capitalone.dashboard.model.Configuration

Bug	Category	Details	Line	Priority
Found reliance on default encoding in com.capitalone.dashboard.model.Configuration.decryptOrEncrptInfo(): new String(byte[])	I18N	DM_DEFAULT_ENCODING	27	High
Found reliance on default encoding in com.capitalone.dashboard.model.Configuration.decryptOrEncrptInfo(): String.getBytes()	I18N	DM_DEFAULT_ENCODING	30	High

com.capitalone.dashboard.model.KeyValueLog

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.model.KeyValueLog.toString() makes inefficient use of keySet iterator instead of entrySet iterator	PERFORMANCE	WMI_WRONG_MAP_ITERATOR	27	Medium

com.capitalone.dashboard.model.LibraryPolicyResult$ThreatComponent

Bug	Category	Details	Line	Priority
Unused field: com.capitalone.dashboard.model.LibraryPolicyResult$ThreatComponent.name	PERFORMANCE	UUF_UNUSED_FIELD		Medium

com.capitalone.dashboard.repository.CustomRepositoryQueryImpl

Bug	Category	Details	Line	Priority
Call to equals(null) in com.capitalone.dashboard.repository.CustomRepositoryQueryImpl.lambda$findCollectorItemsBySubsetOptions$0(Object)	CORRECTNESS	EC_NULL_ARG	41	Medium

com.capitalone.dashboard.request.CloudInstanceListRefreshRequest

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.request.CloudInstanceListRefreshRequest.getRefreshDate() may expose internal representation by returning CloudInstanceListRefreshRequest.refreshDate	MALICIOUS_CODE	EI_EXPOSE_REP	33	Medium
com.capitalone.dashboard.request.CloudInstanceListRefreshRequest.setRefreshDate(Date) may expose internal representation by storing an externally mutable object into CloudInstanceListRefreshRequest.refreshDate	MALICIOUS_CODE	EI_EXPOSE_REP2	37	Medium

com.capitalone.dashboard.request.CloudSubnetListRefreshRequest

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.request.CloudSubnetListRefreshRequest.getRefreshDate() may expose internal representation by returning CloudSubnetListRefreshRequest.refreshDate	MALICIOUS_CODE	EI_EXPOSE_REP	33	Medium
com.capitalone.dashboard.request.CloudSubnetListRefreshRequest.setRefreshDate(Date) may expose internal representation by storing an externally mutable object into CloudSubnetListRefreshRequest.refreshDate	MALICIOUS_CODE	EI_EXPOSE_REP2	37	Medium

com.capitalone.dashboard.request.CloudVirtualNetworkListRefreshRequest

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.request.CloudVirtualNetworkListRefreshRequest.getRefreshDate() may expose internal representation by returning CloudVirtualNetworkListRefreshRequest.refreshDate	MALICIOUS_CODE	EI_EXPOSE_REP	33	Medium
com.capitalone.dashboard.request.CloudVirtualNetworkListRefreshRequest.setRefreshDate(Date) may expose internal representation by storing an externally mutable object into CloudVirtualNetworkListRefreshRequest.refreshDate	MALICIOUS_CODE	EI_EXPOSE_REP2	37	Medium

com.capitalone.dashboard.request.CloudVolumeListRefreshRequest

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.request.CloudVolumeListRefreshRequest.getRefreshDate() may expose internal representation by returning CloudVolumeListRefreshRequest.refreshDate	MALICIOUS_CODE	EI_EXPOSE_REP	33	Medium
com.capitalone.dashboard.request.CloudVolumeListRefreshRequest.setRefreshDate(Date) may expose internal representation by storing an externally mutable object into CloudVolumeListRefreshRequest.refreshDate	MALICIOUS_CODE	EI_EXPOSE_REP2	37	Medium

com.capitalone.dashboard.request.CommitCreateRequest

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.request.CommitCreateRequest doesn't override com.capitalone.dashboard.model.SCM.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium

com.capitalone.dashboard.request.GitRequestCreateRequest

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.request.GitRequestCreateRequest doesn't override com.capitalone.dashboard.model.SCM.equals(Object)	STYLE	EQ_DOESNT_OVERRIDE_EQUALS	1	Medium

com.capitalone.dashboard.util.Encryption

Bug	Category	Details	Line	Priority
Found reliance on default encoding in com.capitalone.dashboard.util.Encryption.decryptString(String, String): new String(byte[])	I18N	DM_DEFAULT_ENCODING	111	High
Found reliance on default encoding in com.capitalone.dashboard.util.Encryption.decryptString(String, SecretKey): new String(byte[])	I18N	DM_DEFAULT_ENCODING	68	High
Found reliance on default encoding in com.capitalone.dashboard.util.Encryption.encryptString(String, String): String.getBytes()	I18N	DM_DEFAULT_ENCODING	89	High
Found reliance on default encoding in com.capitalone.dashboard.util.Encryption.encryptString(String, SecretKey): String.getBytes()	I18N	DM_DEFAULT_ENCODING	48	High

com.capitalone.dashboard.util.SuperFeatureComparator

Bug	Category	Details	Line	Priority
com.capitalone.dashboard.util.SuperFeatureComparator implements Comparator but not Serializable	BAD_PRACTICE	SE_COMPARATOR_SHOULD_BE_SERIALIZABLE	15	Medium